[JENKINS-40422] Inferring credentials resolves wrong credential #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
raul-arabaolaza
force-pushed
the
JENKINS-40422
branch
from
90e63f1 to
a902495
Compare
When you use a separate set of credentials for checkout and scanning it makes sense to use the scan credentials to notify, for example it could be that checkout credentials are of type SSH whilst scan are of type username/ password
raul-arabaolaza
force-pushed
the
JENKINS-40422
branch
from
a902495 to
d88d474
Compare
raul-arabaolaza
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-40422 Use scanCredentials if available over checkoutCredentials when inferring
When you use a separate set of credentials for checkout and scanning
it makes sense to use the scan credentials to notify, for example it could
be that checkout credentials are of type SSH whilst scan are of type username/
password, or even that due to GH API limits both of them may be adecuate
but you want to use the scan ones
@reviewbybees