Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defending against corrupt builds #282

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

Vlatombe
Copy link
Member

I've seen some builds failing during splitTests execution with an exception like

java.lang.NullPointerException: Cannot invoke "hudson.model.Run.getRootDir()" because "this.run" is null
	at hudson.tasks.junit.TestResultAction.getDataFile(TestResultAction.java:139)
	at hudson.tasks.junit.TestResultAction.load(TestResultAction.java:233)
	at hudson.tasks.junit.TestResultAction.getResult(TestResultAction.java:150)
	at hudson.tasks.junit.TestResultAction.getResult(TestResultAction.java:66)
	at org.jenkinsci.plugins.parallel_test_executor.ParallelTestExecutor.getTestResult(ParallelTestExecutor.java:372)
	at org.jenkinsci.plugins.parallel_test_executor.ParallelTestExecutor.findPreviousTestResult(ParallelTestExecutor.java:349)
	at org.jenkinsci.plugins.parallel_test_executor.ParallelTestExecutor.findTestSplits(ParallelTestExecutor.java:196)
	at org.jenkinsci.plugins.parallel_test_executor.SplitStep$Execution.run(SplitStep.java:139)
	at org.jenkinsci.plugins.parallel_test_executor.SplitStep$Execution.run(SplitStep.java:116)
	at org.jenkinsci.plugins.workflow.steps.SynchronousStepExecution.start(SynchronousStepExecution.java:37)
[...]

There may be a bug in the JUnit plugin, or some problem with pipeline persistence that causes it to load the build partially corrupted. In any case, the plugin should defend itself against such state and skip such build.

I don't know how to recreate such a broken run state, so no added test for now.

Testing done

Submitter checklist

Preview Give feedback

@Vlatombe Vlatombe requested a review from a team as a code owner March 14, 2024 09:18
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(ignore ws)

@jglick jglick added the bug label Mar 14, 2024
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up #247.

@jglick jglick merged commit 67474e5 into jenkinsci:master Mar 14, 2024
14 checks passed
@Vlatombe Vlatombe deleted the defend-against-corrupt-builds branch March 14, 2024 11:48
Vlatombe added a commit to Vlatombe/junit-plugin that referenced this pull request Sep 26, 2024
I've seen builds failing in the wild during `junit` step execution with
an exception like

```
java.lang.NullPointerException: Cannot invoke "hudson.model.Run.getRootDir()" because "this.run" is null
	at PluginClassLoader for junit//hudson.tasks.junit.TestResultAction.getDataFilePath(TestResultAction.java:154)
	at PluginClassLoader for junit//hudson.tasks.junit.TestResultAction.loadCached(TestResultAction.java:317)
	at PluginClassLoader for junit//hudson.tasks.junit.TestResultAction.load(TestResultAction.java:279)
	at PluginClassLoader for junit//hudson.tasks.junit.TestResultAction.getResult(TestResultAction.java:166)
	at PluginClassLoader for junit//hudson.tasks.junit.TestResultAction.getResult(TestResultAction.java:70)
	at PluginClassLoader for junit//hudson.tasks.test.AbstractTestResultAction.findCorrespondingResult(AbstractTestResultAction.java:286)
	at PluginClassLoader for junit//hudson.tasks.test.TestResult.getPreviousResult(TestResult.java:146)
	at PluginClassLoader for junit//hudson.tasks.junit.TestResult.getPreviousResult(TestResult.java:467)
	at PluginClassLoader for junit//hudson.tasks.junit.CaseResult.getPreviousResult(CaseResult.java:768)
	at PluginClassLoader for junit//hudson.tasks.junit.CaseResult.recomputeFailedSinceIfNeeded(CaseResult.java:669)
	at PluginClassLoader for junit//hudson.tasks.junit.CaseResult.freeze(CaseResult.java:950)
	at PluginClassLoader for junit//hudson.tasks.junit.SuiteResult.freeze(SuiteResult.java:730)
	at PluginClassLoader for junit//hudson.tasks.junit.TestResult.freeze(TestResult.java:1119)
	at PluginClassLoader for junit//hudson.tasks.junit.TestResultAction.setResult(TestResultAction.java:125)
	at PluginClassLoader for junit//hudson.tasks.junit.TestResultAction.<init>(TestResultAction.java:96)
	at PluginClassLoader for junit//hudson.tasks.junit.JUnitResultArchiver.parseAndSummarize(JUnitResultArchiver.java:301)
	at PluginClassLoader for junit//hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:62)
	at PluginClassLoader for junit//hudson.tasks.junit.pipeline.JUnitResultsStepExecution.run(JUnitResultsStepExecution.java:27)
	at PluginClassLoader for workflow-step-api//org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution.lambda$start$0(SynchronousNonBlockingStepExecution.java:47)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)
```

While the root cause for such corruption is still to be identified, the
plugin should defend against that condition and ignore such a build.

Similar to jenkinsci/parallel-test-executor-plugin#282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants