Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hashcode test really useful #373

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Vlatombe
Copy link
Member

The hashcode test is not testing much really. It is more efficient to check all fields and check whether they change the hashcode.

In the process, I saw that one of the fields (tokenAuthMethods) was missing from the hashCode method computation.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Vlatombe Vlatombe requested a review from a team as a code owner August 23, 2024 16:31
The hashcode test is not testing much really. It is more efficient to
check all fields.
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.44%. Comparing base (b7205f1) to head (46e8cd8).
Report is 18 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #373      +/-   ##
============================================
- Coverage     72.02%   71.44%   -0.58%     
+ Complexity      234      232       -2     
============================================
  Files            11       11              
  Lines           990      991       +1     
  Branches        142      142              
============================================
- Hits            713      708       -5     
- Misses          199      205       +6     
  Partials         78       78              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@michael-doubez michael-doubez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-doubez michael-doubez merged commit 37294ea into jenkinsci:master Aug 27, 2024
18 of 19 checks passed
@Vlatombe Vlatombe deleted the hashcodetest branch August 28, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants