OicUserProperty was discarded after saving the user config page
#332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Jun 6, 2024
| @@ -1,7 +1,5 @@ | |||
| OicLogoutAction.OicLogout = Oic Logout | |||
|
|
|||
| OicUserProperty.OpenIdConnectUserProperty = OpenID Connect user property | |||
Comment on lines
+1273
to
+1274
| assertEquals( | ||
| "User should still be in 2 groups", 2, user.getAuthorities().size()); |
There was a problem hiding this comment.
Before fix, failed with
java.lang.AssertionError: User should still be in 2 groups expected:<2> but was:<0>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.jenkinsci.plugins.oic.PluginTest.testOicUserPropertyDescriptor(PluginTest.java:1270)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #332 +/- ##
============================================
- Coverage 73.35% 73.15% -0.21%
+ Complexity 211 209 -2
============================================
Files 10 10
Lines 882 879 -3
Branches 124 124
============================================
- Hits 647 643 -4
- Misses 172 173 +1
Partials 63 63 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you log in with OIDC with a groups field defined, then go to your user config page and create an API token, then use that API token to run the CLI command
who-am-i, your groups are listed as expected. But if you then Save the same page and try the CLI command again, you are shown as having no groups. This is because saving the page wiped out theOicUserProperty. AFAICT this has been broken since #12. The corrected idiom can be seen inLastGrantedAuthoritiesPropertyin core, a very similar property. Actually we could probably use that instead ofOicUserPropertyby merely callingSecurityListener.fireLoggedIn; I did not try that yet.