Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure login doesn't redirect to logout URL #303

Merged
merged 1 commit into from
May 1, 2024

Conversation

michael-doubez
Copy link
Contributor

@michael-doubez michael-doubez commented Apr 20, 2024

Fixes issue found in #295

Testing done

Live testing:

  • login + logout => end on logout page.
  • while still on logout page, click on login
    • previous version displays error page about incoherent state
    • new version redirect to root url

Submitter checklist

Preview Give feedback

@michael-doubez michael-doubez requested a review from a team as a code owner April 20, 2024 22:44
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.37%. Comparing base (9442607) to head (5412b0f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #303      +/-   ##
============================================
+ Coverage     73.27%   73.37%   +0.09%     
- Complexity      209      210       +1     
============================================
  Files            10       10              
  Lines           872      875       +3     
  Branches        123      124       +1     
============================================
+ Hits            639      642       +3     
  Misses          170      170              
  Partials         63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-doubez michael-doubez linked an issue Apr 21, 2024 that may be closed by this pull request
@michael-doubez michael-doubez self-assigned this Apr 21, 2024
@michael-doubez michael-doubez merged commit ce65d51 into jenkinsci:master May 1, 2024
18 checks passed
@michael-doubez michael-doubez deleted the logout-issues branch May 1, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login while on logout page displays misleading message
1 participant