Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new setting to disable sslVerification - for testing purposes #3

Merged
merged 2 commits into from
Jan 15, 2017

Conversation

triplem
Copy link

@triplem triplem commented Jan 10, 2017

In order to test the plugin in a development/testing environment, we do need to avoid validation of Ssl certificates. This pull request provides a setting, to disable the ssl certificate validation.

BTW, an issue tracker would be nice.

@mjmbischoff
Copy link
Contributor

Intent makes sense to me, although there will be people who abuse this feature it's ok because because that's their problem and for the rest of us who need to evaluate tech, create proof of concepts or debug things, it makes life easier.

As for the impl. it's probably best to move building/instantiating the httpTransport to the constructor since the value that depends on it already known and final at that time. This saves us from some performance overhead of creating it for each request. As per the NetHttpTransport class documentation 'Implementation is thread-safe. For maximum efficiency, applications should use a single globally-shared instance of the HTTP transport.'

I'll see if I can make the changes so it can be merged. Then I should probably release a new version to also get the other pull requests out there.

@triplem
Copy link
Author

triplem commented Jan 15, 2017

Have refactored the construction of the HttpTransport,, so that it is now done in the constructor.

Could you furthermore open the issue tracker?

@mjmbischoff mjmbischoff merged commit c7d9c93 into jenkinsci:master Jan 15, 2017
@mjmbischoff
Copy link
Contributor

I've also enabled the issue tracker.

@mjmbischoff mjmbischoff modified the milestone: 1.1 Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants