Add test for AllNodesBuildParameterFactory class

[yashpal2104]

Testing done

I have added automated tests for the AllNodesBuildParameterFactory class

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did

[yashpal2104]

@MarkEWaite
Here at line 37, 50 and 62 I did try to ignore the trigger build on Jenkins (built-in) which is a node by default triggered to build at the starting by writing a line of code to remove it from the params List but I was not able to remove it so I added '1' to the expected output because the node count is increased by one ultimately.
So is it ok or do I need to figure out to write the code so that the test are more efficient?
I can provide more details on the code I had written if you want me to explain further.

[MarkEWaite]

This looks great. Very nice work.

You could further increase the branch coverage of the getParameters() method if you created a test that set the number of executors of one of the agents to 0. That branch of the getParameters() conditional does not seem to be covered in any of the current tests.

The comments I've made are all optional.

Don't forget to update your local copy of the master branch to match the upstream copy of the master branch.

Also, when creating the pull request description, the checklist formats more nicely if you use [X] something instead of [ X] something. The extra space inside the square brackets causes the GitHub formatter to not show it as a checked box.

[yashpal2104]

Yes these comments accurately depict the workflow and results to expect off of tests. Thank you

Also, when creating the pull request description, the checklist formats more nicely if you use [X] something instead of [ X] something. The extra space inside the square brackets causes the GitHub formatter to not show it as a checked box.

OK I will do this from now