Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify dependencies #258

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Simplify dependencies #258

merged 2 commits into from
Aug 11, 2023

Conversation

MarkEWaite
Copy link
Contributor

Simplif dependencies

  • Use hamcrest assertions instead of assertj
  • Remove explicit parameterized-trigger version

Testing done

Automated tests pass on Java 11 with Linux. Rely on ci.jenkins.io for other tests.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite
Use hamcrest assertions instead of assertj
481b45b 
The hamcrest assertions are very commonly used in Jenkins tests.
The assertj assertions in this plugin were few and easily transformed
into hamcrest assertions.
@MarkEWaite
Remove explicit parameterized-trigger version
aaa97f8
@MarkEWaite MarkEWaite requested a review from a team as a code owner August 11, 2023 20:14
@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Aug 11, 2023
@MarkEWaite MarkEWaite merged commit 5cd08c6 into jenkinsci:master Aug 11, 2023
@MarkEWaite MarkEWaite deleted the simplify-dependency-versions branch August 11, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Automated test addition or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarkEWaite