Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Apache Mina NIO2 framework instead of jdk provided NIO2 framework #133

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Use Apache Mina NIO2 framework instead of jdk provided NIO2 framework #133

merged 2 commits into from
Dec 12, 2024

Conversation

olamy
Copy link
Member

@olamy olamy commented Dec 10, 2024 •
edited by Dohbedoh
Loading

Signed-off-by: Olivier Lamy olamy@apache.org

This should provide better performance. To disable this Jenkins can be started using the system property -Dorg.apache.sshd.common.io.IoServiceFactoryFactory=org.apache.sshd.common.io.nio2.Nio2ServiceFactoryFactory

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@olamy
Use Apache Mina NIO2 framework instead of jdk provided NIO2 framework.
08fe1eb 
This should provide better performance.
To disable this Jenkins can be started using the system property
 `-Dorg.apache.sshd.common.io.IoServiceFactoryFactory=org.apache.sshd.common.io.nio2.Nio2ServiceFactoryFactory`

Signed-off-by: Olivier Lamy <olamy@apache.org>
This was referenced Dec 10, 2024
Closed
Closed
@olamy olamy marked this pull request as ready for review December 10, 2024 03:37
@olamy olamy requested a review from a team as a code owner December 10, 2024 03:37
@jglick jglick changed the title Use Apache Mina NIO2 framework instead of jdk provided NIO2 framework. This should provide better performance. To disable this Jenkins can be started using the system property -Dorg.apache.sshd.common.io.IoServiceFactoryFactory=org.apache.sshd.common.io.nio2.Nio2ServiceFactoryFactory Use Apache Mina NIO2 framework instead of jdk provided NIO2 framework Dec 10, 2024
@olamy
Copy link
Member Author

olamy commented Dec 11, 2024

bom testing jenkinsci/bom#4085

Dohbedoh
Dohbedoh approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@Dohbedoh Dohbedoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests including bom testing / CB URR are passing.
LGTM to move forward.

@Dohbedoh Dohbedoh merged commit 4d2b085 into jenkinsci:main Dec 12, 2024
17 checks passed
@Dohbedoh Dohbedoh added the enhancement New feature or request label Dec 12, 2024
@DragoonAethis
Copy link

DragoonAethis commented Jan 15, 2025 •
edited
Loading

FYI: We recently upgraded Jenkins with all of its plugins and noticed massive log spam + heavy CPU usage with AbstractPollingIoProcessor in Mina, also reported by someone else here: https://issues.jenkins.io/browse/JENKINS-75007 - using the -Dorg.apache.sshd.common.io.IoServiceFactoryFactory=org.apache.sshd.common.io.nio2.Nio2ServiceFactoryFactory override fixed this issue for us. Or not, it still happened, just a day later...

@olamy olamy deleted the use-mina-nio2-framework branch January 20, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dohbedoh Dohbedoh Dohbedoh approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olamy @DragoonAethis @Dohbedoh