Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for BCFIPS Security #114

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix support for BCFIPS Security #114

merged 1 commit into from
Oct 3, 2024

Conversation

olamy
Copy link
Member

@olamy olamy commented Aug 28, 2024

Signed-off-by: Olivier Lamy olamy@apache.org

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@olamy olamy mentioned this pull request Sep 1, 2024
Merged
@Dohbedoh Dohbedoh mentioned this pull request Oct 2, 2024
Merged
6 tasks
@olamy olamy changed the title In FIPS environment using BCFIPS security a custom SecurityProvider needs to be register and due to how classloader is used in Mina this needs to be in the same classloader as org.apache.sshd.common.util.security.SecurityUtils so in mina-sshd-common Upgrade to Apache Mina 2.14.0. In FIPS environment using BCFIPS security a custom SecurityProvider needs to be register and due to how classloader is used in Mina this needs to be in the same classloader as org.apache.sshd.common.util.security.SecurityUtils so in mina-sshd-common Oct 2, 2024
@olamy olamy marked this pull request as ready for review October 2, 2024 23:05
@olamy olamy requested a review from a team as a code owner October 2, 2024 23:05
olamy
olamy commented Oct 2, 2024
View reviewed changes
Jenkinsfile Outdated Show resolved Hide resolved
@olamy olamy force-pushed the bcfips-mina-security-registar branch from 1c73343 to 79bac1e Compare October 3, 2024 00:12
@olamy olamy changed the title Upgrade to Apache Mina 2.14.0. In FIPS environment using BCFIPS security a custom SecurityProvider needs to be register and due to how classloader is used in Mina this needs to be in the same classloader as org.apache.sshd.common.util.security.SecurityUtils so in mina-sshd-common In FIPS environment using BCFIPS security a custom SecurityProvider needs to be register and due to how classloader is used in Mina this needs to be in the same classloader as org.apache.sshd.common.util.security.SecurityUtils so in mina-sshd-common Oct 3, 2024
@Dohbedoh Dohbedoh added the bug Something isn't working label Oct 3, 2024
@olamy olamy force-pushed the bcfips-mina-security-registar branch from 79bac1e to e014bb9 Compare October 3, 2024 00:35
@Dohbedoh Dohbedoh mentioned this pull request Oct 3, 2024
Merged
6 tasks
@olamy olamy force-pushed the bcfips-mina-security-registar branch 2 times, most recently from e9c7593 to f09d8da Compare October 3, 2024 02:09
@olamy
In FIPS environment using BCFIPS security a custom SecurityProvider n…
7d91a9d 
…eeds to be register and due to how classloader is used in Mina this needs to be in the same classloader as org.apache.sshd.common.util.security.SecurityUtils so in mina-sshd-common

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy force-pushed the bcfips-mina-security-registar branch from f09d8da to 7d91a9d Compare October 3, 2024 02:12
Dohbedoh
Dohbedoh approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@Dohbedoh Dohbedoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests! I also quickly tested the incrementals in a non FIPS environment.
LGTM.

@Dohbedoh Dohbedoh changed the title In FIPS environment using BCFIPS security a custom SecurityProvider needs to be register and due to how classloader is used in Mina this needs to be in the same classloader as org.apache.sshd.common.util.security.SecurityUtils so in mina-sshd-common Fix support for BCFIPS Security Oct 3, 2024
@Dohbedoh Dohbedoh merged commit 04e9b6b into jenkinsci:main Oct 3, 2024
17 checks passed
MarkEWaite added a commit to jenkinsci/git-plugin that referenced this pull request Oct 4, 2024
@MarkEWaite
Exclude commons-io from git-client transitive dependencies
1601664 
The mina-sshd-api plugin 2.14.0-131.v04e9b_6b_e0362 included from the
plugin BOM provides a test library that includes commons-io.  Exclude
the transitive dependency from git-client on commons-io.

jenkinsci/mina-sshd-api-plugin#114 includes
the fips-bundle-test library jar into the API plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dohbedoh Dohbedoh Dohbedoh approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olamy @Dohbedoh