[JENKINS-19396] Remove log file clutter from Linux agents started by Windows controllers #323
Conversation
Bumps [maven-reporting-api](https://github.com/apache/maven-reporting-api) from 3.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-reporting-api/releases) - [Commits](apache/maven-reporting-api@maven-reporting-api-3.0...maven-reporting-api-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.reporting:maven-reporting-api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [org.codehaus.plexus:plexus-classworlds](https://github.com/codehaus-plexus/plexus-classworlds) from 2.6.0 to 2.7.0. - [Release notes](https://github.com/codehaus-plexus/plexus-classworlds/releases) - [Commits](codehaus-plexus/plexus-classworlds@plexus-classworlds-2.6.0...plexus-classworlds-2.7.0) --- updated-dependencies: - dependency-name: org.codehaus.plexus:plexus-classworlds dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…aster/org.apache.maven.reporting-maven-reporting-api-3.1.1', 'dependabot/maven/master/org.codehaus.plexus-plexus-classworlds-2.7.0', 'deprecations' and 'patch-1' into octopus
MarkEWaite
changed the title
| protected final String getLoggingPath(MavenInstallation mvn){ | ||
| return (getLauncher().isUnix()?":":";")+mvn.getHome()+"/conf/logging"; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is the key change in the pull request. Instead of using mvn.getHomeDir().getPath(), it uses mvn.getHome()
|
I've tested the pre-release build (https://ci.jenkins.io/job/Plugins/job/maven-plugin/view/change-requests/job/PR-323/) resulting from this pull request in our environment (1 Windows controller, 2 Linux agents) and can confirm, that the job output is not cluttered with "[pool-1-thread- ... " anymore. |
|
I think that this should be labeled "bug" so that it is categorized correctly in the changelog. It would also be fine if it were labeled as "maintenance" if that makes more sense to others. |
|
This plugin does not have CD enabled and I am not intending to release anything. Maybe some other “maintainer” plans to, or maybe @MarkEWaite wants to be added. |
|
Thanks @jglick! I'm using the incremental build in my test environment. I don't feel a pressing need for a release of the plugin. I'm willing to propose myself as a maintainer, though the other maintainers may hesitate to have my aggressive merging of dependency updates on this plugin. It has some special circumstances that make it more complicated than most plugins. |
[JENKINS-19396] Remove log file clutter from Linux agents started by Windows controllers
A maven integration job that is started on a Linux agent by a Windows controller will clutter its output with "[pool-1-thread-4 for channel id=206]" messages that confuse warning parsers and distract users.
The problem does not occur when a Linux controller runs a job on either Windows or Linux.
The problem does not occur when a Windows controller runs a job on a Windows agent.
Original change was provided by @samgabriel in:
Includes other pull request as part of the plugin testing:
CODEOWNERS#317README#320Testing done
No automated test added because the test failure mode requires a Windows controller and a Linux agent. We don't have infrastructure ready to support that type of cross-platform testing.
Tested on Windows controller with Windows agent and Linux agent and on a Linux controller with Windows agent and Linux agent.
Test configuration includes:
Continued testing on my Jenkins configuration.
Submitter checklist