Fix mvn compile in multimodule projects
#235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amuniz
reviewed
Oct 5, 2021
| } else { | ||
| getLog().warn("Skipping jenkins-core validation for " + artifact + " since we rely on sources and don't have a manifest. Use 'package' goal to get validation"); | ||
| // Assume the version is the same | ||
| return new VersionNumber(findJenkinsVersion()); |
There was a problem hiding this comment.
IIRC this could be missing the core version check, as it is not really returning the dependency version but the current project core version. IMO, this should throw an exception pointing the user to run mvn package instead of mvn compile (or any goal before package in the maven lifecycle).
Proper validation runs on mvn deploy so releases are safe, but still... getting mvn test to not catch a Jenkins core version mismatch does not sound good.
There was a problem hiding this comment.
mvn test checks it through InjectedTest, see #191
jglick
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
mvn compileon a multimodule project containing multiple jenkins plugins depending on each other, build is failing withUnable to retrieve manifest.This is because the current validation requires that a manifest is available and expects a packaged file (required
mvn packageat least).This is skipping the validation in this particular case, issuing a warning.