Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list-plugin-dependencies documentation, not all plugins are listed by the mojo #195

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Fix list-plugin-dependencies documentation, not all plugins are listed by the mojo #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/org/jenkinsci/maven/plugins/hpi/ListPluginDependenciesMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@
import java.io.Writer;

/**
* List up all the plugin dependencies.
* List up all plugin dependencies declared in the project.
* Transitive plugin dependencies will not be listed.
*
* @author Kohsuke Kawaguchi
*/
Expand All @@ -26,6 +27,9 @@ public class ListPluginDependenciesMojo extends AbstractHpiMojo {
@Parameter(property = "outputFile")
protected File outputFile;

// TODO(oleg_nenashev): Add support for transitive plugin dependencies.
// Might require reusing/refactoring the plugin dependency tree resolution code in plugin installation mojos.

public void execute() throws MojoExecutionException, MojoFailureException {
try {
Writer w = outputFile==null ? new NullWriter() : new OutputStreamWriter(new FileOutputStream(outputFile),"UTF-8");
Expand Down