Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in change log hpi property #162

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

timja
Copy link
Member

@timja timja commented Nov 25, 2019

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂ , typos got test coverage again. I doubt it is adopted anywhere beyond JCasC, so let's merge it

@oleg-nenashev oleg-nenashev merged commit 735813c into jenkinsci:master Nov 25, 2019
@oleg-nenashev
Copy link
Member

@timja Released it in https://github.com/jenkinsci/maven-hpi-plugin/releases/tag/3.11 . Since we have only 1 plugin affected, I suggest to not expedite the plugin POM release for now. The version of this plugin can be defined via a property. WDYT?

@timja
Copy link
Member Author

timja commented Nov 28, 2019

@timja Released it in 3.11 (release) . Since we have only 1 plugin affected, I suggest to not expedite the plugin POM release for now. The version of this plugin can be defined via a property. WDYT?

I think we can just pick it up in the next plugin-pom release (skip the property override).
As long as it's released before it's widely advertised it's fine

@timja timja deleted the fix-change-log-typo branch November 28, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants