Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated Jenkins version test conditional #149

Conversation

MarkEWaite
Copy link
Contributor

Remove Jenkins version conditional from test

Jenkins version must be at least 2.387.3 as defined in the pom. No need for the test to check if the Jenkins version is older than 2.342, since it must be at least 2.387.3.

Testing done

Automated tests pass with Java 11 on Linux

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Jenkins version must be at least 2.387.3 as defined in the pom.  No need
for the test to check if the Jenkins version is older than 2.342, since
it must be at least 2.387.3.
@daniel-beck daniel-beck merged commit 5f2fae6 into jenkinsci:master Aug 22, 2023
@MarkEWaite MarkEWaite deleted the remove-outdated-jenkins-version-conditional branch January 5, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants