[JENKINS-70906] Compatibility with Prototype removal #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
daniel-beck
changed the title
daniel-beck
commented
May 12, 2023
| @@ -40,15 +40,15 @@ Behaviour.specify(".matrix-auth-add-button", 'GlobalMatrixAuthorizationStrategy' | |||
|
|
|||
| var tooltipAttributeName = getTooltipAttributeName(); | |||
|
|
|||
| findElementsBySelector(copy, ".stop a").each(function(item) { | |||
| findElementsBySelector(copy, ".stop a").forEach(function(item) { | |||
There was a problem hiding this comment.
Tooltips for actions in newly added rows don't have placeholders, but proper labels.
| let oldTitle = item.getAttribute("title"); | ||
| if (oldTitle !== null) { | ||
| item.setAttribute("title", oldTitle.replace("__SID__", name).replace("__TYPE__", typeLabel)); | ||
| } | ||
| item.setAttribute(tooltipAttributeName, item.getAttribute(tooltipAttributeName).replace("__SID__", name).replace("__TYPE__", typeLabel)); | ||
| }); | ||
|
|
||
| findElementsBySelector(copy, "input[type=checkbox]").each(function(item) { | ||
| findElementsBySelector(copy, "input[type=checkbox]").forEach(function(item) { |
There was a problem hiding this comment.
Tooltips for checkboxes in newly added rows don't have placeholders, but proper labels.
| @@ -175,7 +175,7 @@ Behaviour.specify(".global-matrix-authorization-strategy-table TD.stop A.migrate | |||
| if(ambiguousPermissionInputs[i].type == "checkbox") { | |||
| unambiguousPermissionInputs[i].checked |= ambiguousPermissionInputs[i].checked; | |||
| } | |||
| newNameElement.className += ' highlight-entry'; | |||
| newNameElement.classList.add(' highlight-entry'); | |||
There was a problem hiding this comment.
Merge ambiguous row into existing unambiguous row (typically authenticated/anonymous)
| @@ -137,7 +137,7 @@ Behaviour.specify(".global-matrix-authorization-strategy-table TD.stop A.migrate | |||
| var name = tr.getAttribute('name'); | |||
|
|
|||
| var newName = name.replace('[EITHER:', '[USER:'); // migrate_user behavior | |||
| if (this.hasClassName('migrate_group')) { | |||
| if (this.classList.contains('migrate_group')) { | |||
There was a problem hiding this comment.
Identify different behavior for the "migrate to group" button.
| @@ -222,7 +222,7 @@ function getTooltipAttributeName() { | |||
| */ | |||
| Behaviour.specify(".global-matrix-authorization-strategy-table td input", 'GlobalMatrixAuthorizationStrategy', 0, function(e) { | |||
| var table = findAncestor(e, "TABLE"); | |||
| if (table.hasClassName('read-only')) { | |||
| if (table.classList.contains('read-only')) { | |||
There was a problem hiding this comment.
Identify SystemRead / ExtendedRead config forms and keep all checkboxes disabled.
basil
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #139, actual changes are from 4th commit onward.
Compatibility with JENKINS-70906.
Tested with and without jenkinsci/jenkins#7986, including ambiguity-related code and SystemRead / ExtendedRead.