Deeper spotbugs checks

- Increase chance of detecting bugs” - Fix findings
jenkinsci · Oct 20, 2021 · 4c49a3c · 4c49a3c
1 parent 48896bb
commit 4c49a3c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/pom.xml b/pom.xml
@@ -18,6 +18,9 @@
 		<gitHubRepo>jenkinsci/log-file-filter-plugin</gitHubRepo>
 		<jenkins.version>2.289.1</jenkins.version>
 		<java.level>8</java.level>
+        <spotbugs.effort>Max</spotbugs.effort>
+        <spotbugs.failOnError>true</spotbugs.failOnError>
+        <spotbugs.threshold>Low</spotbugs.threshold>
 	</properties>
 
 	<name>Log File Filter Plugin</name>

diff --git a/src/main/java/com/tsystems/sbs/LogFileFilterStep.java b/src/main/java/com/tsystems/sbs/LogFileFilterStep.java
@@ -24,7 +24,9 @@
  */
 public class LogFileFilterStep extends Step implements Serializable {
 
-	@DataBoundConstructor
+    private static final long serialVersionUID = -4144901779369429596L;
+
+    @DataBoundConstructor
     public LogFileFilterStep() {}
 
 	@Override
@@ -36,7 +38,9 @@ public StepExecution start(StepContext context) throws Exception {
      * Execution for {@link LogFileFilterStep}.
      */
     public static class Execution extends AbstractStepExecutionImpl {
-
+
+        private static final long serialVersionUID = -3589168947547448938L;
+
         protected Execution(StepContext context) {
         	super(context);
         }