Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spotbugs 4.8.2 with more exclusions #164

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Use spotbugs 4.8.2 with more exclusions #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
<changelist>-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/lib-${project.artifactId}</gitHubRepo>
<asm.version>9.6</asm.version>
<!-- TODO: Remove when parent pom is using this version or newer -->
<!-- https://github.com/jenkinsci/pom/pull/510 -->
<spotbugs-maven-plugin.version>4.8.2.0</spotbugs-maven-plugin.version>
<spotbugs.omitVisitors>FindReturnRef,ConstructorThrow</spotbugs.omitVisitors>
</properties>

<dependencies>
Expand Down
12 changes: 8 additions & 4 deletions src/spotbugs/excludesFilter.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,14 @@
Exclusions in this section have been triaged and determined to be false positives.
-->
<Match>
<Or>
<!-- Pending https://github.com/spotbugs/spotbugs/issues/1515 -->
<Bug pattern="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED"/>
</Or>
<!-- Pending https://github.com/spotbugs/spotbugs/issues/1515 -->
<Bug pattern="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED"/>
</Match>
<Match>
<!-- Preserve API compatibility -->
<Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
<Class name="org.kohsuke.file_leak_detector.Listener"/>
<Field name="THRESHOLD"/>
</Match>
<!--
Here lies technical debt. Exclusions in this section have not yet been triaged. When working on
Expand Down