Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Degrade gracefully on Java 19+ #145

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Degrade gracefully on Java 19+ #145

merged 1 commit into from
Jun 27, 2023

Conversation

basil
Copy link
Member

@basil basil commented Jun 26, 2023

Without fixing #86, make it so that this module at least degrades gracefully when run on Java 19+, allowing users to use the file handle capability without using the socket capability (which does not work on Java 17+).

Testing done

Ran the unit tests on Java 11, 17, 19, 20, and 21. Also ran the module in a real Jenkins controller and verified I could successfully use the file handle capability on all of those Java versions (at least in a simple use case).

@basil basil added the bug label Jun 26, 2023
@basil basil merged commit d62e819 into jenkinsci:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants