Also load local restrictions from old index location #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
approved these changes
Jul 30, 2021
|
repositories are missing in the pom i assume |
|
Looks that way. Will check in #55. |
MarkEWaite
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
I'm unqualified to assess the change but am confident that @jglick is the right person to make the change. If there is a surprise, we'll adapt to the surprise.
|
Makes the IT in jenkinsci/plugin-pom#428 pass at least. |
…fier into local-restrictions
This was referenced Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had thought I could skip the local index in #53, on the grounds that
Both assumptions were apparently wrong:
annotation-indexerfrom core plugin-pom#426 means that if${jenkins.version}predates 2.289.x, we will indeed run a new access checker tool while the current plugin (target/classes/) has been built against an old annotation indexer.@Restricted(NoExternalUse.class)is implemented means that if you do not loadtarget/classes/META-INF/annotations/org.kohsuke.accmod.Restricted, the build will fail when another class in the current source root refers to the annotated API.