Remove unnecessary SpotBugs exclusions (#126)

jenkinsci · Nov 22, 2022 · 5b17d5e · 5b17d5e
1 parent b088898
commit 5b17d5e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/...odifier-annotation/src/main/java/org/kohsuke/accmod/restrictions/ProtectedExternally.java b/...odifier-annotation/src/main/java/org/kohsuke/accmod/restrictions/ProtectedExternally.java
@@ -50,7 +50,7 @@ public class ProtectedExternally extends None {
 
     @Override
     @SuppressFBWarnings(
-            value={"RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE","RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE", "NP_LOAD_OF_KNOWN_NULL_VALUE"},
+            value={"RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE", "NP_LOAD_OF_KNOWN_NULL_VALUE"},
             justification="something in this class confuses spotbugs, I can't see anything redundant and the error line is the catch block")
     public void invoked(Location loc, RestrictedElement target, ErrorListener errorListener) {
         if (target.isInTheInspectedModule()) {

diff --git a/access-modifier-checker/src/main/java/org/kohsuke/accmod/impl/EnforcerMojo.java b/access-modifier-checker/src/main/java/org/kohsuke/accmod/impl/EnforcerMojo.java
@@ -55,12 +55,9 @@ public class EnforcerMojo extends AbstractMojo {
 
     @Override
     @SuppressFBWarnings(value = {
-            "UWF_UNWRITTEN_FIELD",
             "URLCONNECTION_SSRF_FD",
-            "UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD",
             "PATH_TRAVERSAL_IN",
-            "DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED",
-            "NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD"
+            "DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED"
     })
     public void execute() throws MojoExecutionException, MojoFailureException {
         if (skip) {