[JENKINS-60551] Copy constructor test should check all fields #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vlatombe
commented
Dec 20, 2019
| PodTemplate pt = new PodTemplate(); | ||
| pt.setName("podTemplate"); | ||
|
|
||
| KubernetesCloud cloud = new KubernetesCloud("name"); | ||
| cloud.setDefaultsProviderTemplate("default"); | ||
| ArrayList<String> objectProperties = Lists.newArrayList("templates", "podRetention", "podLabels", "labels"); |
There was a problem hiding this comment.
This hunk should prevent any further unhandled field in the future.
* Default jelly values from java constants * Apply min values for readTimeout (15 sec) and connectTimeout (5 sec) * Add missing serverCertificate, readTimeout and capOnlyOnAlivePods to copy constructor
Vlatombe
force-pushed
the
JENKINS-60551
branch
from
bab940e to
368ec74
Compare
|
Se also #625 (comment) & JENKINS-59984, though this is about cloud-level configuration rather than pods. |
jglick
approved these changes
Dec 20, 2019
src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesCloud.java
Show resolved
Hide resolved
src/main/resources/org/csanchez/jenkins/plugins/kubernetes/KubernetesCloud/config.jelly
Outdated
Show resolved
Hide resolved
src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesCloud.java
Outdated
Show resolved
Hide resolved
* Use XStream for copy constructor * Convert fields with numeric input to f:number with minimum * Validate integer are in expected ranges
jglick
approved these changes
Dec 20, 2019
src/main/resources/org/csanchez/jenkins/plugins/kubernetes/KubernetesCloud/config.jelly
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-60551
readTimeout(15 sec) andconnectTimeout(5 sec)serverCertificate,readTimeoutandcapOnlyOnAlivePodstocopy constructor