Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-50437] Env vars using PATH+SOMETHING syntax clear the previous env var #301

Merged
merged 2 commits into from
Mar 28, 2018
Merged

[JENKINS-50437] Env vars using PATH+SOMETHING syntax clear the previous env var #301

merged 2 commits into from
Mar 28, 2018

Conversation

carlossg
Copy link
Contributor

@carlossg carlossg commented Mar 27, 2018 •
edited
Loading

@carlossg
Copy link
Contributor Author

FYI @MattLud

@oleg-nenashev
Copy link
Member

Test failures are definitely related to this change :(
It should fix the issue tho

@Vlatombe
[JENKINS-50437] Filter out environment variables coming from computer
ccf4634 
but keep everything else.

notation KEY+FOO=bar seems to be prepended in my setup and in CI so
inverting the order in the assertion
@carlossg carlossg merged commit 2ab94c9 into master Mar 28, 2018
@carlossg carlossg deleted the JENKINS-50437-path-plus branch March 28, 2018 19:14
oleg-nenashev
oleg-nenashev reviewed Mar 28, 2018
View reviewed changes
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Belated 🐝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-nenashev oleg-nenashev oleg-nenashev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlossg @oleg-nenashev @MattLud @Vlatombe