Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dummy descriptor for KubernetesLauncher #1563

Merged

Conversation

Vlatombe
Copy link
Member

KubernetesLauncher is a Describable but as it is only instantiated programmatically. Not having a matching Descriptor class is not a problem for daily operations in the plugin, but some code may request for computer.launcher.descriptor and produce walls of exceptions for no good use.

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Avoids exceptions should some code ever request for `computer.launcher.descriptor`
@Vlatombe Vlatombe added the bug Bug Fixes label May 29, 2024
@Vlatombe Vlatombe requested a review from a team as a code owner May 29, 2024 07:45
@Vlatombe Vlatombe merged commit 234076a into jenkinsci:master May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants