Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce KubernetesDeclarativeAgentRJRTest #1494

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Introduce KubernetesDeclarativeAgentRJRTest #1494

merged 1 commit into from
Jan 10, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 9, 2024

jenkinsci/workflow-cps-plugin#538 (comment) not successful yet despite

diff --git pom.xml pom.xml
index df3627bc..f95064a8 100644
--- pom.xml
+++ pom.xml
@@ -134,6 +134,7 @@
     <dependency>
       <groupId>org.jenkins-ci.plugins.workflow</groupId>
       <artifactId>workflow-cps</artifactId>
+      <version>3832.vc43e04d6d68c</version>
       <optional>true</optional>
     </dependency>
     <dependency>

but it seems appropriate to at least have some test coverage here.

@jglick jglick requested a review from a team as a code owner January 9, 2024 16:06
@jglick jglick requested a review from dwnusbaum January 9, 2024 16:07
@jglick jglick added the test Tests label Jan 9, 2024
@jglick jglick mentioned this pull request Jan 9, 2024
Merged
6 tasks
@jglick jglick mentioned this pull request Jan 9, 2024
Merged
@Vlatombe Vlatombe merged commit 8a13bd0 into jenkinsci:master Jan 10, 2024
6 checks passed
@jglick jglick deleted the KubernetesDeclarativeAgentRJRTest branch January 16, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnusbaum dwnusbaum dwnusbaum approved these changes

@Vlatombe Vlatombe Vlatombe approved these changes

Assignees
No one assigned
Labels
test Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jglick @Vlatombe @dwnusbaum