Issue 1. Fix prepending of erroneous /api/v1beta1 to test-connection HT... #1
Conversation
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
I have committed the doc and the fix. Abut the new tests, I'm not sure starting a new stub server is a good idea, I think there should be only 2 types of tests:
|
|
Thanks btw. I'm trying to cut a first release, but lacking permissions, hopefully soon will get that deployed to the update center |
|
No problem on the embedded http server. Also, you can probably cherry-pick this commit that gives the jelly templates help icons that describe the fields the plugin has control of: https://github.com/xoom/kubernetes-plugin/commit/18f4a7df351074a7ef9621d763924781b7f6074d Feel free to decline this PR now that it's work is done. The URL fix was sufficiently trivial that nothing will really be lost with the discarding of the embedded http server test. In retrospect, I should have done this work on a different branch than my fork's master. Live and learn. |
|
Can you create a new PR for 18f4a7d so it gets tracked? Easier for me to merge too |
|
Done. On Wed, Apr 15, 2015 at 8:44 AM, Carlos Sanchez notifications@github.com
Mark |
java.lang.AssertionError: Jenkins is still doing something after 1000ms: queue=[] building=[run Dir Context jenkinsci#1] at org.jvnet.hudson.test.JenkinsRule.waitUntilNoActivityUpTo(JenkinsRule.java:1877) at org.csanchez.jenkins.plugins.kubernetes.pipeline.KubernetesPipelineTest.allDead(KubernetesPipelineTest.java:96) at … "Running CpsFlowExecution[Owner[run Dir Context/1:run Dir Context jenkinsci#1]]" Id=4356 Group=main RUNNABLE (in native) at sun.nio.ch.FileDispatcherImpl.force0(Native Method) at sun.nio.ch.FileDispatcherImpl.force(FileDispatcherImpl.java:80) at sun.nio.ch.FileChannelImpl.force(FileChannelImpl.java:388) at hudson.util.FileChannelWriter.close(FileChannelWriter.java:89) at hudson.util.AtomicFileWriter.close(AtomicFileWriter.java:174) at hudson.util.AtomicFileWriter.commit(AtomicFileWriter.java:188) at hudson.XmlFile.write(XmlFile.java:198) at org.jenkinsci.plugins.workflow.support.PipelineIOUtils.writeByXStream(PipelineIOUtils.java:30) at org.jenkinsci.plugins.workflow.job.WorkflowRun.save(WorkflowRun.java:1158) - locked org.jenkinsci.plugins.workflow.job.WorkflowRun@2ad5551b at hudson.BulkChange.commit(BulkChange.java:98) at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.notifyListeners(CpsFlowExecution.java:1475) at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$3.run(CpsThreadGroup.java:458) at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:38) at …
Adjust after changes to kubernetes-credentials
...TP GET