Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize Jenkins container command validation #199

Closed
pawelprazak opened this issue Nov 15, 2019 · 1 comment
Closed

Generalize Jenkins container command validation #199

pawelprazak opened this issue Nov 15, 2019 · 1 comment
Assignees
@tomaszsek
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
Minimal OpenShift...

Comments

@pawelprazak
Copy link

pawelprazak commented Nov 15, 2019 •
edited by tomaszsek
Loading

To allow for various versions of jenkins container, we need to change validation of the master container command to only check for prefix:

  - command:
    - bash
    - -c
    - /var/jenkins/scripts/init.sh && ...

and make sure that signals are propagated(to kill the process correctly).
@pawelprazak pawelprazak added the enhancement New feature or request label Nov 15, 2019
@pawelprazak pawelprazak mentioned this issue Nov 15, 2019
Closed
13 tasks
@pawelprazak pawelprazak added this to the Minimal OpenShift support milestone Nov 15, 2019
@pawelprazak pawelprazak mentioned this issue Nov 15, 2019
Closed
@pawelprazak pawelprazak added the help wanted Extra attention is needed label Nov 15, 2019
@tomaszsek tomaszsek mentioned this issue Nov 28, 2019
Closed
@tomaszsek tomaszsek assigned tomaszsek and waveywaves and unassigned tomaszsek Dec 16, 2019
tomaszsek added a commit that referenced this issue Jan 18, 2020
@tomaszsek
#199 Generalize Jenkins container command validation
bf07fa5
@tomaszsek tomaszsek assigned tomaszsek and unassigned waveywaves Apr 2, 2020
@tomaszsek
Copy link

Added in https://github.com/jenkinsci/kubernetes-operator/releases/tag/v0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomaszsek tomaszsek

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
Minimal OpenShift support [0.4.0]
Development

No branches or pull requests
3 participants
@pawelprazak @waveywaves @tomaszsek