Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable resources.limits and resources.requests default values if not set #194

Closed
akram opened this issue Nov 14, 2019 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@akram
Copy link

akram commented Nov 14, 2019

Some users may want to keep values for resources limits and resources requests to unset in order to benefit for more container density in their kubernetes infrastructure.
This is allowed by kubernetes by not setting any value for resources.requests nor resources.limits

https://kubernetes.io/docs/tasks/configure-pod-container/quality-service-pod/#create-a-pod-that-gets-assigned-a-qos-class-of-besteffort

Currently, the Jenkins operator sets default values for these and operates reconciliation of these values.

It is preferable to keep these values unsynchronized.

@pawelprazak pawelprazak added the enhancement New feature or request label Nov 14, 2019
@pawelprazak
Copy link

pawelprazak commented Nov 15, 2019

Yes, we'd like to remove the defaults in favour of CR example and a warning:

  • remove resource limit and request default - no longer enforce defaults
  • add warning (in logs and k8s events) for mem limit < 512MB and cpu limit < 1, as not recommended config (mitigate default low container quota)

@tomaszsek
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants