-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-36305] Fix TestObject url in order to fix TestActions links #50
Changes from all commits
5e9935e
40cfa0a
04c8855
541992f
1a3a45d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -104,12 +104,9 @@ public final String getId() { | |
return id; | ||
} | ||
|
||
/** | ||
* Returns url relative to TestResult | ||
*/ | ||
@Override | ||
public String getUrl() { | ||
return '/' + getId(); | ||
return getRun().getUrl() + getTestResultAction().getUrlName() + "/" + getId(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. at first glance this could break https://github.com/jenkinsci/cucumber-testresult-plugin There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not really sure how to test this =/, I tried with the tests in https://github.com/jenkinsci/cucumber-testresult-plugin and these: https://github.com/testdouble/java-cucumber-example |
||
} | ||
|
||
public String getFullDisplayName() { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could deprecate the old method and introduce a replacement intended to have different behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had documented the problem in
https://issues.jenkins-ci.org/browse/JENKINS-36305?focusedCommentId=262717&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-262717
I don't see how it can be fixed otherwise.