Pluggable storage: Add stdout, stderr, stacktrace, fix caseresult loading #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
commented
Sep 24, 2020
| @@ -134,14 +134,24 @@ public CaseResult(SuiteResult parent, String testName, String errorStackTrace, S | |||
| } | |||
|
|
|||
| @Restricted(Beta.class) | |||
| public CaseResult(SuiteResult parent, String className, String testName, String errorDetails, String skippedMessage, float duration) { | |||
| public CaseResult( | |||
There was a problem hiding this comment.
ignoring compat break as it's beta and only user is sql plugin which will be released at the same time
timja
commented
Sep 24, 2020
| } else { | ||
| result = getClassResult(name); | ||
| } | ||
| ClassResult result = getClassResult(name); |
There was a problem hiding this comment.
get by package result also loads the full class result, this code before was ignoring the package and only worked in tests because we had a Klazz and a other.Klazz. and so the wrong Klazz was being picked.
Now we load from the correct package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.