-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-72981] Inline EZMorph repository #8
Conversation
Does the ezmorph source tree contain a |
I make a readonly git repository replica covert from origin cvs repo. https://github.com/BobDu/ezmorph In the original repository, there are no additional |
Signed-off-by: Bob Du <i@bobdu.cc>
e056960
to
1cf9067
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Can you also copy over the package.html
files from the original repository? We have the package.html
files for JSON-lib in this repository, so we should keep the package.html
files from EZMorph to be consistent.
What's the reason for removing the unused files in commit 1cf9067, and how do you know they are unused? In theory the only way to prove that a plugin isn't consuming them would be using https://github.com/jenkins-infra/usage-in-plugins. And this also dilutes the semantics of this PR, since it's now doing two things, a code import and a code cleanup. I think I would rather let this PR be a simple import and defer the code cleanup to another PR, unless there was a particular reason to do so here.
Origin
+1, I will revert this commit in this PR |
Signed-off-by: Bob Du <i@bobdu.cc>
1cf9067
to
c799d68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I have confirmed that these sources exactly match the contents of the 1.0.6 sources JAR on Maven Central and the CVS repository checked out via:
cvs -z3 -d:pserver:anonymous@ezmorph.cvs.sourceforge.net:/cvsroot/ezmorph co -r REL_1_0_6 -P ezmorph
There was a minor textual merge conflict in the log4j properties file, which I resolved in favor of EZMorph to ensure that tests have proper debug logs.
json-lib
has a exclusive dependency libaryezmorph
Currently, we not have a fork for
ezmorph
. However, the refactoring work will inevitably involve modifications to the content ofezmorph
. Considering the singularity of dependencies. It is also unnecessary to separately splitezmorph
into an independent repository and jar package.So, attempting merge
ezmorph
into this repository.I make a
ezmorph
readonly git mirror from origin cvs for reference, and copy all java code into this repo.https://github.com/BobDu/ezmorph
@basil
Testing done
Submitter checklist