Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump commons-beanutils from 1.7.0 to 1.9.4 #5

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 4, 2020

Bumps commons-beanutils from 1.7.0 to 1.9.4.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 4, 2020
@narendrabtechcse
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@basil
Copy link
Member

basil commented Apr 11, 2024

@dependabot rebase

@dependabot dependabot bot changed the base branch from 2.1.x to master April 11, 2024 20:13
@dependabot dependabot bot force-pushed the dependabot/maven/commons-beanutils-commons-beanutils-1.9.4 branch from f7ba1c5 to bdcbed9 Compare April 11, 2024 20:13
@basil
Copy link
Member

basil commented Apr 11, 2024

@dependabot rebase

Bumps commons-beanutils from 1.7.0 to 1.9.4.

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/maven/commons-beanutils-commons-beanutils-1.9.4 branch from bdcbed9 to b908a18 Compare April 11, 2024 21:15
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduces four new test failures.

@BobDu
Copy link
Member

BobDu commented Apr 12, 2024

ref: jenkinsci/jenkins#5324

It seems that commons-beanutils 1.9.4 has introduced breaking changes for security reasons. However, should we only need to make changes to the unit tests? This is because the core has already been using the new version of the dependency for three years.

@basil
Copy link
Member

basil commented Apr 12, 2024

Right, this is just a matter of updating the tests to keep the CI build passing.

@BobDu
Copy link
Member

BobDu commented Apr 13, 2024

Right, this is just a matter of updating the tests to keep the CI build passing.

make a new PR #22 to manual bump commons-beanutils.

@BobDu
Copy link
Member

BobDu commented Apr 13, 2024

@dependabot close

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 13, 2024

Sorry, only users with push access can use that command.

@basil
Copy link
Member

basil commented Apr 13, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 13, 2024

Looks like commons-beanutils:commons-beanutils is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Apr 13, 2024
@dependabot dependabot bot deleted the dependabot/maven/commons-beanutils-commons-beanutils-1.9.4 branch April 13, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants