Remove commons-collections
#34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobDu
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
LGTM
However, it should be noted that we haven't actually removed commons-collections from the dependency tree of json-lib. Because it is still shipped as a transitive dependency through commons-beanutils.
A possible solution would be to copy the org/apache/commons/collections/FastHashMap.java file into json-lib src. (Similar to the behavior of beanutils before version 1.9. )
I would be willing to open a new PR in the future to discuss its feasibility.
|
Indeed, and it wasn't my goal to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since JDK 1.5 there are native equivalents for all of this functionality.
Testing done
mvn clean verify