Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73453] make icons in table buttons resizable #9482

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Jul 18, 2024

With #9131 the css class jenkins-table__button was replaced at certain places with jenkins-button. But this change caused regressions:

  • The icon size for large table was almost the same as that for medium tables
  • The icons wrapped in jenkins-button were not resizable
  • with small table the buttons overflowed the table cell

Before:
image
image
image

After:
image
image
image

This change restores the old icon size for large tables and adds additional css rules for jenkins-button inside tables so they are properly resized and the padding is correct

See JENKINS-73453.

Testing done

Manual testing

Proposed changelog entries

  • Change icon size in table when resizing the table.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

With jenkinsci#9131 the jenkins-table__button was replaced at certain places with
jenkins-button. But this change caused two regressions:
- The icon size for large table was almost the same as that for medium
  tables
- The icons wrapped in jenkins-button were not resizable
- with small table the buttons overflowed the table cell

This change restores the old icon size for large tables and adds
additional css rules for jenkins-button inside tables so they are
properly resized and the padding is correct
@mawinter69 mawinter69 changed the title [JENKINS-73543] make icon in buttons in tables resizable [JENKINS-73543] make icons in table buttons resizable Jul 18, 2024
@daniel-beck daniel-beck added regression-fix Pull request that fixes a regression in one of the previous Jenkins releases bug For changelog: Minor bug. Will be listed after features labels Jul 18, 2024
@NotMyFault NotMyFault requested a review from a team July 19, 2024 14:29
@NotMyFault
Copy link
Member

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 20, 2024
@MarkEWaite MarkEWaite changed the title [JENKINS-73543] make icons in table buttons resizable [JENKINS-73453] make icons in table buttons resizable Jul 20, 2024
@NotMyFault NotMyFault removed the bug For changelog: Minor bug. Will be listed after features label Jul 21, 2024
@NotMyFault NotMyFault merged commit 19d568c into jenkinsci:master Jul 21, 2024
15 checks passed
NotMyFault pushed a commit to NotMyFault/jenkins that referenced this pull request Aug 14, 2024
[JENKINS-73543] make icon in buttons in tables resizable

With jenkinsci#9131 the jenkins-table__button was replaced at certain places with
jenkins-button. But this change caused two regressions:
- The icon size for large table was almost the same as that for medium
  tables
- The icons wrapped in jenkins-button were not resizable
- with small table the buttons overflowed the table cell

This change restores the old icon size for large tables and adds
additional css rules for jenkins-button inside tables so they are
properly resized and the padding is correct

(cherry picked from commit 19d568c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants