-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modernise build time trend page #9465
Conversation
- use jenkins-table - add time since column - make the link to the console an explicit icon (like for the agent history) - hide the agent column for pipeline jobs
184fdb1
to
1487e02
Compare
@jenkinsci/sig-ux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks good!
jenkinsci/jenkins#9465 improves the build time trend page by adding a "time since" column and an explicit icon that links to the console output. It also hides the agent column for Pipeline jobs and allows the table to be resized. Check that those very nice improvements do not break any of the tests in the plugin bill of materials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed the checks in the plugin bill of materials. Passed my interactive testing of both freestyle job without an agent, freestyle job with an agent, and Pipeline job with an agent.
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
Before:
pipeline job:
freestyle job:
After:
pipeline job:
freestyle job:
Testing done
Manual testing
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist