Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernise build time trend page #9465

Merged
merged 7 commits into from
Jul 22, 2024

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented Jul 14, 2024

  • use jenkins-table
  • add time since column
  • make the link to the console an explicit icon (like for the agent history)
  • hide the agent column for pipeline jobs
  • allow to resize the table

Before:
pipeline job:
image

freestyle job:
image

After:
pipeline job:
image

freestyle job:
image

Testing done

Manual testing

Proposed changelog entries

  • Modernize the build time trend page with a time since column, a link to the console, and allow the table to be resized. Remove the agent column for the Pipeline build trend.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

- use jenkins-table
- add time since column
- make the link to the console an explicit icon (like for the agent
  history)
- hide the agent column for pipeline jobs
@mawinter69
Copy link
Contributor Author

@jenkinsci/sig-ux

@NotMyFault NotMyFault requested a review from a team July 19, 2024 15:03
@timja timja added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise labels Jul 19, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good!

MarkEWaite added a commit to MarkEWaite/bom that referenced this pull request Jul 20, 2024
jenkinsci/jenkins#9465 improves the build time
trend page by adding a "time since" column and an explicit icon that links
to the console output.  It also hides the agent column for Pipeline jobs
and allows the table to be resized.

Check that those very nice improvements do not break any of the tests
in the plugin bill of materials.
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed the checks in the plugin bill of materials. Passed my interactive testing of both freestyle job without an agent, freestyle job with an agent, and Pipeline job with an agent.

@timja
Copy link
Member

timja commented Jul 21, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 21, 2024
@NotMyFault NotMyFault merged commit e9d210a into jenkinsci:master Jul 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants