Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow update sites to define a custom URL for wizard plugin suggestion #8951

Merged
merged 4 commits into from
Feb 18, 2024

Conversation

olamy
Copy link
Member

@olamy olamy commented Feb 12, 2024

Use case: a unique distribution with two json files:

  • the usual one,
  • a second one with a limited list. Some plugins maybe not be compatible with the startup mode (e.g FIPS mode)

currently the file is hardcoded and there is not extension point available with the setup wizard

Testing done

Proposed changelog entries

  • Add ability for custom update center's to override the suggested plugin list

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@olamy olamy added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Feb 12, 2024
@NotMyFault NotMyFault requested a review from a team February 12, 2024 13:09
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a PR to jenkins.io with the system property please?

https://github.com/jenkins-infra/jenkins.io/edit/master/content/doc/book/managing/system-properties.adoc

…ake it configurable

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy force-pushed the suggested-plugins-file-configurable branch from 3ecd4cf to 569c8b0 Compare February 13, 2024 10:57
@olamy
Copy link
Member Author

olamy commented Feb 13, 2024

@timja timja requested a review from a team February 13, 2024 11:25
Signed-off-by: Olivier Lamy <olamy@apache.org>
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
@daniel-beck daniel-beck added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Feb 15, 2024
@timja
Copy link
Member

timja commented Feb 15, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Feb 15, 2024
@timja timja added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted developer Changes which impact plugin developers and removed rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Feb 15, 2024
@timja
Copy link
Member

timja commented Feb 15, 2024

I've reworded the changelog can you please take a look @olamy

@daniel-beck daniel-beck changed the title currently suggested plugins list as setup time is hardcoded, we can make it configurable Allow update sites to define a custom URL for wizard plugin suggestion Feb 16, 2024
@olamy
Copy link
Member Author

olamy commented Feb 18, 2024

I've reworded the changelog can you please take a look @olamy

Thanks

@timja timja merged commit 824f64c into jenkinsci:master Feb 18, 2024
17 checks passed
@olamy olamy deleted the suggested-plugins-file-configurable branch February 19, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Changes which impact plugin developers ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants