Update appearance of buttons for password and secretTextarea matching 'jenkins-button's

[mawinter69]

replace old style buttons with new jenkins-button

Before:

After:

Testing done

Manual testing
create password credential and update it
create ssh username with private key credential and update it
Verified that things still work as expected

Proposed changelog entries

• Update appearance of buttons for password and secretTextarea matching 'jenkins-button's.

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[mawinter69]

The plugin https://plugins.jenkins.io/hp-application-automation-tools-plugin/ has a selector on the input button here:
https://github.com/jenkinsci/hpe-application-automation-tools-plugin/blob/425f167f1f78b8f80adab875150dceebdd8d1044/src/main/webapp/js/almUtils.js#L75

[Wadeck]

👍 Fine security wise

[NotMyFault]

Thanks!

[NotMyFault]

/label ready-for-merge

---

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

[MarkEWaite]

A minor test change was needed in the docker-commons plugin as a result of the change from textarea to input for the secret text field. Change is in:

• Adapt DockerServerCredentialsTest for 2.413+ credentials page docker-commons-plugin#140

Other plugins that use HTMLUnit to create credentials may need a similar change.

I'm a little perplexed that SecretTextAreaTest in Jenkins core is not affected by the same change, but I assume it is not affected because the secret button that is being created in that test is using the old secrets button instead of the newer and better looking secrets button.

@mawinter69 does that make sense to you, or have I misunderstood something?

I didn't find any other matches for plugins using HTMLUnit to create credentials. It seems much easier to me to create test credentials from Java objects rather than using the web interface to do it.

[mawinter69]

The change in core also changed in the test the way the button is selected and clicked. The same problem is in docker-commons. The button is not clicked (it looks for an input but is now a button) that is why the content is still in an input and not a textarea.