[JENKINS-60866] Extract inline JS from progressive rendering #6860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-60866.
Right now I am feeling pretty good about our ability to make
st:bind
CSP-compliant in a compatible way (that ended up in #6865). This PR just extracts inline JS fromprogressiveRendering
that is defined there directly.This tag is used e.g. for
/asynchPeople/
.I checked whether any callbacks exist that aren't just function names via GH search and did not find any (but that's not a thorough search).
The chosen approach should be compatible with pages having multiple
progressiveRendering
, but not with AJAX suppliedprogressiveRendering
(which I doubt exist, but cannot be sure). Please let me know if this should be done with Behavior instead.Proposed changelog entries
Too minor (unless we count the redefinition of the argument)
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgrade@Restricted
or have@since TODO
Javadoc, as appropriate.@Deprecated(since = "TODO")
or@Deprecated(forRemoval = true, since = "TODO")
if applicable.Desired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are accurate, human-readable, and in the imperative moodupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).