Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JEP-224 GA system read permission #4909

Merged
merged 3 commits into from
Aug 25, 2020

Conversation

timja
Copy link
Member

@timja timja commented Aug 13, 2020

See JEP-224.

See jenkinsci/jep#297

See https://groups.google.com/g/jenkinsci-dev/c/qCJ7Qkn_D2s/m/2dXdE_LJAgAJ

Proposed changelog entries

  • Entry 1: JEP-224, Graduate Overall/SystemRead to GA status.
  • ...

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@timja timja requested a review from oleg-nenashev August 13, 2020 20:48
@oleg-nenashev oleg-nenashev added major-rfe For changelog: Major enhancement. Will be highlighted on the top web-ui The PR includes WebUI changes which may need special expertise labels Aug 13, 2020
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unclear what the benefit of enabling these by default is.

For me, "GA" and "enabled by default" are two different states, and while one is very likely to require the other, it's not the direction that this PR seems to imply.

Given how painful permissions management in Jenkins already is, adding to the permissions matrix should be carefully considered instead of making it a necessary part of declaring a feature GA. And in this case, we're not adding just one, but three permissions.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a weak preference towards enabling the permissions by default. At the same time, I agree with @daniel-beck that it is not required for making JEP-224 a GA. API cleanup is enough.

For permissions, I suggest to create a a separate PR for JEP-224 GA and to use this one for a wider discussion about permission defaults with the @jenkinsci/core team.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🥇

@timja timja marked this pull request as ready for review August 19, 2020 07:28
@timja timja requested a review from a team August 19, 2020 07:28
@timja timja changed the title JEP-224 GA extended and system read permissions JEP-224 GA system read permission Aug 19, 2020
@oleg-nenashev
Copy link
Member

We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process

@oleg-nenashev oleg-nenashev added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Aug 24, 2020
@timja timja merged commit 40916d7 into jenkinsci:master Aug 25, 2020
@timja timja deleted the ga-system-and-extended-read-permissions branch August 25, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-rfe For changelog: Major enhancement. Will be highlighted on the top ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants