-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JEP-224 GA system read permission #4909
JEP-224 GA system read permission #4909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is unclear what the benefit of enabling these by default is.
For me, "GA" and "enabled by default" are two different states, and while one is very likely to require the other, it's not the direction that this PR seems to imply.
Given how painful permissions management in Jenkins already is, adding to the permissions matrix should be carefully considered instead of making it a necessary part of declaring a feature GA. And in this case, we're not adding just one, but three permissions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a weak preference towards enabling the permissions by default. At the same time, I agree with @daniel-beck that it is not required for making JEP-224 a GA. API cleanup is enough.
For permissions, I suggest to create a a separate PR for JEP-224 GA and to use this one for a wider discussion about permission defaults with the @jenkinsci/core team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🥇
We may merge it in 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process |
See JEP-224.
See jenkinsci/jep#297
See https://groups.google.com/g/jenkinsci-dev/c/qCJ7Qkn_D2s/m/2dXdE_LJAgAJ
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).