Add job duration as tooltip to build time in the build history widget #4453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
added
rfe
oleg-nenashev
approved these changes
Jan 26, 2020
res0nance
reviewed
Jan 26, 2020
|
Here a small screenshot: |
|
Retrigger CI |
res0nance
approved these changes
Jan 29, 2020
rsandell
approved these changes
Jan 30, 2020
rsandell
reviewed
Jan 30, 2020
| <a class="tip model-link inside build-link" href="${link}" update-parent-class=".build-row"> | ||
| <j:set var="linkTitleAttr" value=""/> | ||
| <j:if test="${!build.building}"> | ||
| <j:set var="linkTitleAttr">${%Took} ${build.durationString}</j:set> |
There was a problem hiding this comment.
The I18n string should probably be parameterized with ${build.durationString} not all languages write it in that order.
There was a problem hiding this comment.
Some hint on how to do that?
There was a problem hiding this comment.
Here are some docs which are far from ideal: https://wiki.jenkins.io/display/JENKINS/Internationalization#Internationalization-Markingmessagesinjellyfiles
|
Is something missing for a merge? |
|
re-triggering build |
oleg-nenashev
added
the
ready-for-merge
|
I plan to merge it tomorrow if no negative feedback |
|
Thanks for your contribution @mguillem ! |
oleg-nenashev
changed the title
jsoref
pushed a commit
to jsoref/jenkins
that referenced
this pull request
Feb 6, 2020
…ion-tooltip add job duration as tooltip to build time
|
Caused JENKINS-72743 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simply adds the build duration as a tooltip of the displayed build date/time in the job's build history. This allows to quickly get the information without having to go to the build history trend page.
Proposed changelog entries