Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-introduce support for Junit5 tests not having JenkinsRule as parameter #909

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Re-introduce support for Junit5 tests not having JenkinsRule as parameter #909

merged 1 commit into from
Jan 24, 2025

Conversation

Vlatombe
Copy link
Member

#907 (comment)

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

timja
timja approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks!

@timja timja added the bug label Jan 24, 2025
@timja timja merged commit ab3a21a into jenkinsci:master Jan 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strangelookingnerd strangelookingnerd strangelookingnerd approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vlatombe @timja @strangelookingnerd