Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tolerate missing DEBUG_YUI field #874

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Tolerate missing DEBUG_YUI field #874

merged 1 commit into from
Nov 14, 2024

Conversation

basil
Copy link
Member

@basil basil commented Nov 14, 2024

Gracefully deal with the case where DEBUG_YUI is not defined in core.

Testing done

Ran a test successfully both with and without DEBUG_YUI defined in core.

MarkEWaite
MarkEWaite approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@basil basil merged commit e3f890c into jenkinsci:master Nov 14, 2024
15 checks passed
@basil basil deleted the debug-yui branch November 14, 2024 18:24
@basil basil mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basil @MarkEWaite