Use new IM-plugin support for "Bot.commandPrefixRequired" toggle [JENKINS-17380, JENKINS-58927] #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Klimov <jimklimov+jenkinsci@gmail.com>
…l; fix small typo Signed-off-by: Jim Klimov <jimklimov+jenkinsci@gmail.com>
…to not require a commandPrefix (on IRCPrivateChat) [JENKINS-17380, JENKINS-58927] Signed-off-by: Jim Klimov <jimklimov+jenkinsci@gmail.com>
jimklimov
force-pushed
the
JENKINS-17380
branch
from
9915c2a
to
705a394
Compare
Signed-off-by: Jim Klimov <jimklimov+jenkinsci@gmail.com>
jimklimov
force-pushed
the
JENKINS-17380
branch
from
d2a25f2
to
03ec668
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As posted in https://issues.jenkins.io/browse/JENKINS-17380 and https://issues.jenkins.io/browse/JENKINS-58927 currently the IRC Bot allows interaction via private chats (admin to bot) as opposed to group channels; however this still requires using the command prefix or nickname prefix - which is cumbersome in an already individualized private chat.
The culprit was in the common instant-messaging-plugin, where it recognizes if the message is of interest to the bot, by requiring those prefixes. A viable solution (also backwards-compatible for users who would continue to use the prefixes) is to have an option to not-require the prefix and just try using any received message, if the consumer plugin told this bot instance to do so (not default!) See jenkinsci/instant-messaging-plugin#210 for the upstream change.
After merging and releasing an IM plugin iteration with this change, there need to be fixes applied to this plugin to use the new constructor API for private chats.
CC @Flowdalic : You may want to update jabber-plugin similarly?
Testing done
TBD
Submitter checklist