Merge pull request #164 from jimklimov/pircbot-snapshot

pom.xml: try pircbotx build "master-SNAPSHOT" not "master"…

Jenkinsfile

@@ -2,7 +2,12 @@
  * See the documentation for more options:
  * https://github.com/jenkins-infra/pipeline-library/
  */
-buildPlugin(useContainerAgent: true, configurations: [
+buildPlugin(
+ useContainerAgent: true,
+ // Opt-in to the Artifact Caching Proxy? (maybe to be removed when it will be opt-out)
+ // See https://github.com/jenkins-infra/helpdesk/issues/2752 for more details and updates.
+ artifactCachingProxyEnabled: false,
+ configurations: [
   // Test the common case (i.e., a recent LTS release) on both Linux and Windows.
   [ platform: 'linux', jdk: '11', jenkins: '2.375.1' ],
   [ platform: 'windows', jdk: '11', jenkins: '2.375.1' ],

pom.xml

@@ -74,8 +74,17 @@
             </exclusions>
         </dependency>
         <dependency>
-            <groupId>com.github.pircbotx</groupId>
+            <groupId>org.pircbotx</groupId>
+            <!-- groupId>com.github.pircbotx</groupId -->
             <artifactId>pircbotx</artifactId>
+
+            <!-- SEE BELOW ABOUT VERSIONING WOES until release 2.4 -->
+            <!-- Finally cheated by uploading (Deploy button) the JAR from JitPack
+                 to https://repo.jenkins-ci.org/ snapshots; metadata parsed and
+                 name/version assigned automatically by it; note it also reassigned
+                 the groupId back to "org.pircbotx"; see also maven enforcer hacks: -->
+            <version>2.4-20230523.142555-1</version>
+
             <!-- https://jitpack.io/#pircbotx/pircbotx => Branches => master-SNAPSHOT
                  => https://jitpack.io/com/github/pircbotx/pircbotx/-v2.3-gb1b48bf-9/build.log
                  Using recent previews until 2.4 which should fix packaging
@@ -87,7 +96,9 @@
             <version>master-SNAPSHOT</version>
             -->
             <!-- <version>b1b48bfb64</version> -->
-            <version>master</version>
+            <!-- <version>master</version> -->
+            <!-- <version>master-v2.3-gb1b48bf-9</version> -->
+
             <scope>compile</scope>
             <exclusions>
                 <!-- provides an ancient version, junit plugin is pulling in a more recent one -->
@@ -133,6 +144,13 @@
                 <enabled>true</enabled>
             </snapshots>
         </repository>
+        <repository>
+            <id>jenkins-artifactory-snapshots</id>
+            <url>https://repo.jenkins-ci.org/artifactory/snapshots</url>
+            <snapshots>
+                <enabled>true</enabled>
+            </snapshots>
+        </repository>
         <repository>
             <id>jitpack.io</id>
             <url>https://jitpack.io</url>
@@ -207,6 +225,38 @@
                     <compatibleSinceVersion>2.0</compatibleSinceVersion>
                 </configuration>
             </plugin>
+
+            <!-- For the time being, until pircbotx-2.4 is officially released,
+                 we are constrained to using snapshots, which is frowned upon.
+                 See centralized config in
+                 https://github.com/jenkinsci/plugin-pom/blob/ec78ae1af0b5365d8d17121f3d5be720acb87f13/pom.xml#L550-L570
+              -->
+            <plugin>
+                <artifactId>maven-enforcer-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <id>no-snapshots-in-release</id>
+                        <phase>validate</phase>
+                        <goals>
+                            <!-- goal>enforce</goal -->
+                            <goal>display-info</goal>
+                        </goals>
+                        <configuration>
+                            <rules>
+                                <requireReleaseDeps>
+                                    <message>No SNAPSHOT versions are allowed for releases (except pircbotx)</message>
+                                    <excludes>
+                                        <exclude>org.pircbotx:pircbotx</exclude>
+                                        <exclude>com.github.pircbotx:pircbotx</exclude>
+                                    </excludes>
+                                </requireReleaseDeps>
+                            </rules>
+                            <fail>true</fail>
+                        </configuration>
+                    </execution>
+                </executions>
+            </plugin>
+
         </plugins>
     </build>