Support for Maven reproducible builds #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
Apr 12, 2024
| @@ -100,6 +100,7 @@ public void afterSessionStart(MavenSession session) throws MavenExecutionExcepti | |||
| hash = head.abbreviate(ABBREV_LENGTH).name(); | |||
| try (RevWalk walk = new RevWalk(repo)) { | |||
| RevCommit headC = walk.parseCommit(head); | |||
| timestamp = DateTimeFormatter.ISO_INSTANT.format(Instant.ofEpochSecond(headC.getCommitTime())); | |||
There was a problem hiding this comment.
Should produce a string such as 2024-04-12T19:40:42Z which seems to align with https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74682318#Reproducible/VerifiableBuilds-OutputArchiveEntriesTimestamp though it is vague about allowed precision.
|
@basil I am ready to merge this and release 1.8 unless you have any last-minute requests? |
|
No last-minute requests on my side. Thank you! |
MarkEWaite
pushed a commit
to jenkins-infra/jenkins.io
that referenced
this pull request
Apr 12, 2024
|
https://github.com/jenkinsci/incrementals-tools/releases/tag/parent-1.8 ought to be available on Central shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Maven reproducible builds when Maven Release Plugin is not in use, regardless of whether
project.build.outputTimestampis (as would be the case for a plugin that still used MRP for production releases but used Incrementals for PR releases) or is not (as would be the case for a plugin that fully implemented automated release) defined inpom.xml.Testing done
Verified that when passing
-Dset.changelistMaven couldn't verify an incrementals build withmvn clean verify artifact:comparebefore this PR but could verify it after this PR.Fixes #103