WIP: add kubernetes auth #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
k8s auth support was merged into the master branch of |
|
Version 4.1.0 of the vault java driver was released today. I should be able to get this working now. |
|
The Jenkins pipeline cannot build the plugin. Getting the below error after updating pom.xml to use vault-java-driver 4.1.0. Seems like this is the most important part of the log ... More of the log ... |
|
Would be really useful to see this get merged. For that errors it looks like Restricted to JDK 1.8 yet com.bettercloud:vault-java-driver:jar:4.1.0:compile contains module-info.class targeted to 53.0 the maven enforcer plugin is enforcing 1.8 but the new vault-java-driver dependency uses 1.9? And Found Banned Dependency: com.bettercloud:vault-java-driver:jar:4.1.0 It looks like both rules come from the parent pom.xml https://github.com/jenkinsci/plugin-pom/blob/master/pom.xml#L529 I'm not sure the standard practice for jenkins plugins but for the banned dependency I think you could just add an exclusion to this projects pom.xml? As for the version mismatch, I'm not sure best way to go about it. https://jenkins.io/doc/administration/requirements/java/ says both java 8 and 11 are supported now, so I think you could override that to allow java 11 in the pom.xml, but then this plugin then requires your jenkins to run java 11. Other option I guess would be to recompile the new vault-java-driver to target 1.8, which doesn't seem all that great either. |
jetersen
requested changes
Jul 31, 2019
| String token = null; | ||
|
|
||
| // TODO: add error handle here | ||
| String jwt = new String(Files.readAllBytes(Paths.get("/var/run/secrets/kubernetes.io/serviceaccount/token"))); |
There was a problem hiding this comment.
This will only work for Linux 😭
|
With the updated POM as of #31 using v4.1.0 is no problem. Which is ancient: Mar 22, 2017 |
|
https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fhashicorp-vault-plugin/detail/PR-18/8/pipeline#log-99 is a legit error :) @seanmalloy are you good to go fixing the compile errors? 😅 |
|
Yes. I should have time to get this all working soon.
…--
Sean Malloy
On Fri, Aug 2, 2019, 1:59 PM Joseph Petersen ***@***.***> wrote:
https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fhashicorp-vault-plugin/detail/PR-18/8/pipeline#log-99
is a legit error :)
@seanmalloy <https://github.com/seanmalloy> are you good to go fixing the
compile errors? 😅
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18?email_source=notifications&email_token=AAFHJJJC7DQQAEOONGNKUTDQCR7XNA5CNFSM4FNVN36KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3OSPKQ#issuecomment-517810090>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFHJJPRHS7QTCMGR35JYMTQCR7XNANCNFSM4FNVN36A>
.
|
|
We are already using vault-java-driver 5.0.0 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request does not compile yet. It has not been tested yet.
This pull request depends on BetterCloud/vault-java-driver#122. Also, a new version of the vault-java-driver will need to be released before this will compile.