Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning while setting a GitLab Multipipeline project or organization folders without Credentials #406

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

manangoel99
Copy link

The PR addresses this issue. While setting up a GitLab multipipeline project or organization folders, a user can choose to not provide any credentials which can lead to an error downstream.
A way to mitigate this is by adding a warning for users to add credentials while still letting them proceed further in the process.

In order to do this, a new validation check doCheckCredentialsId has been added to gitlab-branch-source-plugin/src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMSource.java and gitlab-branch-source-plugin/src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMNavigator.java which checks if credentials are provided or not. The implementation of these is based on the existing Gitea plugin.

Screenshots of the outcome attached below.

image
image

Submitter checklist

Preview Give feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant