Add warning while setting a GitLab Multipipeline project or organization folders without Credentials #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses this issue. While setting up a GitLab multipipeline project or organization folders, a user can choose to not provide any credentials which can lead to an error downstream.
A way to mitigate this is by adding a warning for users to add credentials while still letting them proceed further in the process.
In order to do this, a new validation check
doCheckCredentialsId
has been added togitlab-branch-source-plugin/src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMSource.java
andgitlab-branch-source-plugin/src/main/java/io/jenkins/plugins/gitlabbranchsource/GitLabSCMNavigator.java
which checks if credentials are provided or not. The implementation of these is based on the existing Gitea plugin.Screenshots of the outcome attached below.
Submitter checklist