Log missing admin access on INFO level #299
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know what the motivation was to log this on DEBUG only (less verbose logs?), but IMO you're missing quite important info this way in the default log level INFO.
I.e. when a new hook should be created, you only see in the logs:
INFO o.j.p.g.webhook.WebhookManager$1#run: GitHub webhooks activated for job X with [GitHubRepositoryName[...]] (events: [PUSH])
which looks like it's successful already ('webhooks activated')
but you miss the DEBUG message which says that you have a correct repo configured, but missing the admin rights
`