Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72317] Use Jenkins.READ permission check for all list box models #684

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Nov 14, 2023

Additionally, use permissions for a BuildableItem in all validations.

See https://issues.jenkins.io/browse/JENKINS-72317 for details.

Additionally, use permissions for a `BuildableItem` in all validations.
@uhafner uhafner added the bug Bugs or performance problems label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c247d5) 85.50% compared to head (cd1bd1b) 85.37%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #684      +/-   ##
============================================
- Coverage     85.50%   85.37%   -0.13%     
+ Complexity      212      211       -1     
============================================
  Files            26       26              
  Lines           807      807              
  Branches         84       84              
============================================
- Hits            690      689       -1     
  Misses           88       88              
- Partials         29       30       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner marked this pull request as ready for review November 15, 2023 08:02
@uhafner uhafner merged commit acc454e into main Nov 15, 2023
26 of 27 checks passed
@uhafner uhafner deleted the permissions-listbox branch November 15, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant