Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-60940] - Migration of GitAPITests from JUnit 3 to JUnit 4 #666

Merged
merged 2 commits into from
Feb 20, 2021

Conversation

GAyan17
Copy link
Contributor

@GAyan17 GAyan17 commented Feb 19, 2021

JENKINS-60940 - Migration of GitAPITests from JUnit 3 to JUnit 4

Added Class GitAPITest, for migration of GitAPITestCase from JUnit 3 to JUnit 4, added the first test getRemoteUrl

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

What types of changes does your code introduce?

  • Infrastructure change (non-breaking change which updates dependencies or improves infrastructure)

…to JUnit 4, added the first test getRemoteUrl
@GAyan17 GAyan17 changed the title [JENKINS-60940] [JENKINS-60940] - Migration of GitAPITests from JUnit 3 to JUnit 4 Feb 19, 2021
@MarkEWaite
Copy link
Contributor

This looks very good. I'd like the pull request to include the removal of the test from GitAPITestCase so that it is clear in the single pull request that the test is moving from one location to another

@GAyan17
Copy link
Contributor Author

GAyan17 commented Feb 20, 2021

@MarkEWaite Sure, I will do that. And should I update more tests in this PR, or should I make another if in case you wish to merge this?

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing it.

Once we have the base file included (was GitClientTest in the examples I created, is now GitAPITest in what you've created), then I prefer more small pull requests rather than fewer, larger pull requests.

@GAyan17
Copy link
Contributor Author

GAyan17 commented Feb 20, 2021

Thanks @MarkEWaite,
Small PR approach seems reasonable, it would help to avoid any big errors or failures, and tracking will be easy. I would follow that, as of now I have migrated smaller tests as suggested. Should I commit them for review?

@MarkEWaite MarkEWaite merged commit 8746199 into jenkinsci:master Feb 20, 2021
@MarkEWaite
Copy link
Contributor

Thanks @MarkEWaite,
Small PR approach seems reasonable, it would help to avoid any big errors or failures, and tracking will be easy. I would follow that, as of now I have migrated smaller tests as suggested. Should I commit them for review?

Yes, that would be great. I've merged this change so that you have the base class available for subsequent pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants